🤖 Add defensive checks for init-output and message processing #413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes two issues found after PR #228: 1. **Init-output undefined line crash**: Added null check for data.line before calling trimEnd(). Prevents crash when init-output events arrive with missing line data during replay or out-of-order scenarios. 2. **Message processing condition tightened**: Added 'role' field check to ensure only CmuxMessages are processed in the caught-up branch. This makes the condition symmetric with the buffering branch and ensures we don't accidentally process malformed messages. Both changes follow the defensive programming pattern established in PR #228 - gracefully handle edge cases during replay rather than crash. _Generated with `cmux`_
Log errors when: - init-output arrives without init-start - init-output has missing line field - init-end arrives without init-start - message in WorkspaceStore doesn't match any processing condition This helps debug edge cases and prevents silent failures.
Add typeof check after line assignment to handle any edge case where data.line might become undefined after the initial null check. This provides defense-in-depth against malformed events from any source (disk corruption, IPC errors, etc.).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
After #228 merged, encountered two issues:
StreamingMessageAggregator.ts:516throwsCannot read properties of undefined (reading 'trimEnd')when processing init-output events with missinglinefieldSolution
1. Init-output defensive check
Added null check for
data.linebefore callingtrimEnd():Follows the defensive pattern from #228 - gracefully handle edge cases during replay.
2. Message processing condition tightened
Added
'role' in datacheck to the caught-up branch:Makes the condition symmetric with the buffering branch and ensures only valid CmuxMessages are processed.
Testing
make typecheckpassesGenerated with
cmux